fix: Fix rendered header error #3590
Conversation
Bundle ReportChanges will decrease total bundle size by 12 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3590 +/- ##
=======================================
Coverage 99.00% 99.00%
=======================================
Files 810 810
Lines 14557 14557
Branches 4139 4139
=======================================
Hits 14412 14412
Misses 138 138
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3590 +/- ##
=======================================
Coverage 99.00% 99.00%
=======================================
Files 810 810
Lines 14557 14557
Branches 4146 4139 -7
=======================================
Hits 14412 14412
Misses 138 138
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3590 +/- ##
=======================================
Coverage 99.00% 99.00%
=======================================
Files 810 810
Lines 14557 14557
Branches 4139 4139
=======================================
Hits 14412 14412
Misses 138 138
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3590 +/- ##
=======================================
Coverage 99.00% 99.00%
=======================================
Files 810 810
Lines 14557 14557
Branches 4146 4146
=======================================
Hits 14412 14412
Misses 138 138
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Bundle ReportChanges will decrease total bundle size by 12 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
suejung-sentry
force-pushed
the
sshin/3028
branch
from
bfed395 to
addf7d7
Compare
suejung-sentry
force-pushed
the
sshin/3028
branch
from
4a95bcb to
670366b
Compare
When there is an error in the network calls in the Header component, fail silently (so no Header displays) instead of rendering the upside down umbrella fallback, resulting in double upside down umbrella in some cases, like here.
This should close #3028.
It will still be nice to do the work in #3081 to have a more refined fallback strategy to show toasts or other specific behavior upon the different kinds of errors possible in the header. For now with this PR there is a catchall behavior of showing no Header so it is less jarring for the user.