ref: Migrate to isTeamPlan GQ field
#3592
Conversation
Bundle ReportChanges will increase total bundle size by 1.27kB (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3592 +/- ##
=======================================
Coverage 99.00% 99.00%
=======================================
Files 810 810
Lines 14557 14569 +12
Branches 4146 4154 +8
=======================================
+ Hits 14412 14424 +12
Misses 138 138
Partials 7 7
... and 2 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3592 +/- ##
=======================================
Coverage 99.00% 99.00%
=======================================
Files 810 810
Lines 14557 14569 +12
Branches 4139 4161 +22
=======================================
+ Hits 14412 14424 +12
Misses 138 138
Partials 7 7
... and 2 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3592 +/- ##
=======================================
Coverage 99.00% 99.00%
=======================================
Files 810 810
Lines 14557 14569 +12
Branches 4139 4154 +15
=======================================
+ Hits 14412 14424 +12
Misses 138 138
Partials 7 7
... and 2 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3592 +/- ##
=======================================
Coverage 99.00% 99.00%
=======================================
Files 810 810
Lines 14557 14569 +12
Branches 4146 4161 +15
=======================================
+ Hits 14412 14424 +12
Misses 138 138
Partials 7 7
... and 2 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Bundle ReportChanges will increase total bundle size by 1.27kB (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
RulaKhaled
force-pushed
the
update-isTeamPlan
branch
from
dca781e to
6ddc688
Compare
| @@ -48,7 +49,7 @@ const UpdateBlurb = ({ | |||
| {diffSeats && ( | |||
| <li className="pl-2">{`You are changing seats from ${currentPlan?.planUserCount} to [${seats}]`}</li> | |||
| )} | |||
| {diffBillingType && ( | |||
| {diffBillingType && !currentIsFree && ( | |||
There was a problem hiding this comment.
weird this is showing up, I thought I had committed it already
Description
This PR aims to remove the isTeamPlan helper function in Gazebo in favor of the new GraphQL field for the same.
fyi we're gonna come back once available plans is refactored to pass down isTeamPlan instead of checking for plans enum for the selected plans, this is just a weird edge case.
Notable Changes
Screenshots
nothing visual changed
issue: #2998
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.