Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Pin demo repo to top during sort #3598

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

spalmurray-codecov
Copy link
Contributor

@spalmurray-codecov spalmurray-codecov commented Dec 19, 2024

Pins the demo repo to the top of the repo list during sorts. Also hides the demo if two or more repos are configured.

Closes codecov/engineering-team#2827

@spalmurray-codecov spalmurray-codecov marked this pull request as ready for review December 19, 2024 22:21
Copy link

codecov bot commented Dec 19, 2024

Bundle Report

Changes will increase total bundle size by 137 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 6.0MB 67 bytes (0.0%) ⬆️
gazebo-production-system-esm 6.05MB 70 bytes (0.0%) ⬆️

@codecov-staging
Copy link

codecov-staging bot commented Dec 19, 2024

Bundle Report

Changes will increase total bundle size by 137 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system-esm 6.05MB 70 bytes (0.0%) ⬆️
gazebo-staging-system 6.0MB 67 bytes (0.0%) ⬆️

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.00%. Comparing base (358f6ec) to head (197b9c1).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3598   +/-   ##
=======================================
  Coverage   99.00%   99.00%           
=======================================
  Files         810      810           
  Lines       14557    14562    +5     
  Branches     4139     4150   +11     
=======================================
+ Hits        14412    14417    +5     
  Misses        138      138           
  Partials        7        7           
Files with missing lines Coverage Δ
src/shared/ListRepo/ReposTable/ReposTable.tsx 98.61% <100.00%> (+0.10%) ⬆️
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.75% <ø> (ø)
Services 99.36% <ø> (ø)
Shared 99.32% <100.00%> (+<0.01%) ⬆️
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 358f6ec...197b9c1. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3598   +/-   ##
=======================================
  Coverage   99.00%   99.00%           
=======================================
  Files         810      810           
  Lines       14557    14562    +5     
  Branches     4139     4150   +11     
=======================================
+ Hits        14412    14417    +5     
  Misses        138      138           
  Partials        7        7           
Files with missing lines Coverage Δ
src/shared/ListRepo/ReposTable/ReposTable.tsx 98.61% <100.00%> (+0.10%) ⬆️
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.75% <ø> (ø)
Services 99.36% <ø> (ø)
Shared 99.32% <100.00%> (+<0.01%) ⬆️
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 358f6ec...197b9c1. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.00%. Comparing base (358f6ec) to head (197b9c1).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3598   +/-   ##
=======================================
  Coverage   99.00%   99.00%           
=======================================
  Files         810      810           
  Lines       14557    14562    +5     
  Branches     4139     4150   +11     
=======================================
+ Hits        14412    14417    +5     
  Misses        138      138           
  Partials        7        7           
Files with missing lines Coverage Δ
src/shared/ListRepo/ReposTable/ReposTable.tsx 98.61% <100.00%> (+0.10%) ⬆️
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.75% <ø> (ø)
Services 99.36% <ø> (ø)
Shared 99.32% <100.00%> (+<0.01%) ⬆️
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 358f6ec...197b9c1. Read the comment docs.

Copy link

codecov-public-qa bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.00%. Comparing base (358f6ec) to head (197b9c1).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3598   +/-   ##
=======================================
  Coverage   99.00%   99.00%           
=======================================
  Files         810      810           
  Lines       14557    14562    +5     
  Branches     4146     4150    +4     
=======================================
+ Hits        14412    14417    +5     
  Misses        138      138           
  Partials        7        7           
Files with missing lines Coverage Δ
src/shared/ListRepo/ReposTable/ReposTable.tsx 98.61% <100.00%> (+0.10%) ⬆️
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.75% <ø> (ø)
Services 99.36% <ø> (ø)
Shared 99.32% <100.00%> (+<0.01%) ⬆️
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 358f6ec...197b9c1. Read the comment docs.

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Dec 19, 2024

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
e73a6e2 Thu, 19 Dec 2024 22:25:04 GMT Expired Expired
197b9c1 Fri, 20 Dec 2024 18:11:59 GMT Cloud Enterprise

@spalmurray-codecov
Copy link
Contributor Author

Tested in preview deploy and working as expected!

@spalmurray-codecov spalmurray-codecov added this pull request to the merge queue Dec 20, 2024
Merged via the queue into main with commit 9034486 Dec 20, 2024
54 checks passed
@spalmurray-codecov spalmurray-codecov deleted the spalmurray/pin-demo-repo branch December 20, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A pin bug on Codecov demo link
3 participants