Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update helpView.ts for changes to organization name #1571

Merged
merged 5 commits into from
Oct 5, 2023

Conversation

worksofliam
Copy link
Contributor

@worksofliam worksofliam commented Oct 4, 2023

Changes

Description of change here.

Checklist

  • have tested my change
  • updated relevant documentation
  • Remove any/all console.logs I added
  • eslint is not complaining
  • have added myself to the contributors' list in CONTRIBUTING.md
  • for feature PRs: PR only includes one feature enhancement.

Copy link
Collaborator

@sebjulliand sebjulliand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good.
But while you're at it, why not replace all references to halcyon-tech by codefori?

By the look of it, a simple replace all should do the trick 😄 (in README, CONTRIBUTING, package, pr.yaml, etc)

@worksofliam
Copy link
Contributor Author

@sebjulliand Didn't think about that! Please check again :)

@sebjulliand sebjulliand linked an issue Oct 5, 2023 that may be closed by this pull request
package.json Outdated Show resolved Hide resolved
Copy link
Collaborator

@sebjulliand sebjulliand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. There are two places where Halcyon remains and may be changed:

  • In package.json (see suggestion)
  • In LICENSE, it says Copyright (c) 2022 Halcyon Tech Ltd; should it be Copyright (c) 2023 Code4i now? (year is wrong too 😅)

@worksofliam
Copy link
Contributor Author

@sebjulliand Done!

@sebjulliand
Copy link
Collaborator

@sebjulliand Done!

Nice! But don't forget to push 😁

@chrjorgensen
Copy link
Collaborator

@worksofliam Is there a redirect from the old name to the new one? Or are all links in issues etc. now broken? Noticed that Scott referenced the old name in his presentation at the IBM Champions IBM i Updates briefing...

@worksofliam
Copy link
Contributor Author

@chrjorgensen The following link still works, but I am guessing it won't by the time next week comes around.

https://github.com/halcyon-tech/vscode-ibmi

@worksofliam
Copy link
Contributor Author

@sebjulliand I pushed. I had a weird situation where my remote broke right in the middle of this PR (still using the old halcyon-tech namespace). Fixed it now and pushed up.

Copy link
Collaborator

@sebjulliand sebjulliand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved and merged! Good job @worksofliam !

@sebjulliand sebjulliand merged commit 4658273 into master Oct 5, 2023
1 check passed
@sebjulliand sebjulliand deleted the worksofliam-patch-1 branch October 5, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Get started" link no longer works
3 participants