-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update helpView.ts for changes to organization name #1571
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good.
But while you're at it, why not replace all references to halcyon-tech
by codefori
?
By the look of it, a simple replace all should do the trick 😄 (in README, CONTRIBUTING, package, pr.yaml, etc)
@sebjulliand Didn't think about that! Please check again :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. There are two places where Halcyon remains and may be changed:
- In
package.json
(see suggestion) - In
LICENSE
, it saysCopyright (c) 2022 Halcyon Tech Ltd
; should it beCopyright (c) 2023 Code4i
now? (year is wrong too 😅)
@sebjulliand Done! |
Nice! But don't forget to push 😁 |
@worksofliam Is there a redirect from the old name to the new one? Or are all links in issues etc. now broken? Noticed that Scott referenced the old name in his presentation at the IBM Champions IBM i Updates briefing... |
@chrjorgensen The following link still works, but I am guessing it won't by the time next week comes around. |
@sebjulliand I pushed. I had a weird situation where my remote broke right in the middle of this PR (still using the old |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved and merged! Good job @worksofliam !
Changes
Description of change here.
Checklist
console.log
s I added