Split Object browser's Refresh in two separate actions #1574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refresh all (original) - Refresh selected item (new) Signed-off-by: Seb Julliand <sjulliand@arcadsoftware.com>
sebjulliand
added
bug
chrjorgensen
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #1555
The
code-for-ibmi.refreshObjectBrowserused to accept no parameter; after converting the Object Browser to TypeScript, that command was changed to accept a TreeItem in parameter, to allow finer refreshes. It turns out that the browsers selected item was always passed onto the command when theRefreshinline button was clicked.This PR revert that change so the command behave as it used to (i.e. clicking on
Refreshrefreshes the entire browser.It also adds a new
code-for-ibmi.refreshObjectBrowserItemcommand that is dedicated to refreshing the browser selected item. ARefreshaction has been added on every browser's item to enable refresh at every level.Checklist