-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Refresh option to actions #1624
Conversation
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
@sebjulliand I will do the Danish translations, just need some clarification for the refresh: I thought a refresh was always done after running an action. Is it not? And what are the new default? |
Nope, no refresh happened so far (hence #658); so this adds the refresh capability. and by default, no refresh happens (all actions default to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sebjulliand Looking good to me. 👍
I made the Danish translations (in a few attempts) and merged the master branch into this PR to resolve a conflict.
Please promote the PR from draft when you feel like it, and I will approve and merge.
Brilliant, thank you so much @chrjorgensen ! I'll wait for #1611 to be approved and merged before promoting this one as this code relies on some types shared by both browsers (i.e. |
Changes
Resolves #658
This PR adds a new
Refresh
options to actions.When this option is set to something else than
no
, then a refresh can occur after the action is done, if the action is run on a Browser item.Parent
: the direct parent container of the item is refreshed (e.g. Source File, Library, Folder)Filter
: the parent filter of the item is refreshedBrowser
: the browser containing the item is entirely refreshed@chrjorgensen : there are a few new translations required for the
da
locale 😉Note: this PR must be merged after #1611 - it will be a draft until then.
Checklist