Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Refresh option to actions #1624

Merged
merged 7 commits into from
Nov 18, 2023
Merged

Added Refresh option to actions #1624

merged 7 commits into from
Nov 18, 2023

Conversation

sebjulliand
Copy link
Collaborator

Changes

Resolves #658

This PR adds a new Refresh options to actions.
image

When this option is set to something else than no, then a refresh can occur after the action is done, if the action is run on a Browser item.

  • Parent : the direct parent container of the item is refreshed (e.g. Source File, Library, Folder)
  • Filter : the parent filter of the item is refreshed
  • Browser : the browser containing the item is entirely refreshed

@chrjorgensen : there are a few new translations required for the da locale 😉

Note: this PR must be merged after #1611 - it will be a draft until then.

Checklist

  • have tested my change
  • for feature PRs: PR only includes one feature enhancement.

Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
@sebjulliand sebjulliand added the enhancement New feature or request label Nov 1, 2023
@sebjulliand sebjulliand requested a review from a team November 1, 2023 13:55
@sebjulliand sebjulliand self-assigned this Nov 1, 2023
@chrjorgensen
Copy link
Collaborator

@sebjulliand I will do the Danish translations, just need some clarification for the refresh: I thought a refresh was always done after running an action. Is it not? And what are the new default?

@sebjulliand
Copy link
Collaborator Author

@sebjulliand I will do the Danish translations, just need some clarification for the refresh: I thought a refresh was always done after running an action. Is it not? And what are the new default?

Nope, no refresh happened so far (hence #658); so this adds the refresh capability. and by default, no refresh happens (all actions default to no).

Copy link
Collaborator

@chrjorgensen chrjorgensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sebjulliand Looking good to me. 👍

I made the Danish translations (in a few attempts) and merged the master branch into this PR to resolve a conflict.

Please promote the PR from draft when you feel like it, and I will approve and merge.

@sebjulliand
Copy link
Collaborator Author

Brilliant, thank you so much @chrjorgensen ! I'll wait for #1611 to be approved and merged before promoting this one as this code relies on some types shared by both browsers (i.e. BrowserItem) but only in TypeScript.

@worksofliam worksofliam added this to the 2.5.0 release milestone Nov 17, 2023
@sebjulliand sebjulliand marked this pull request as ready for review November 18, 2023 20:33
@sebjulliand sebjulliand merged commit 4b20187 into master Nov 18, 2023
1 check passed
@sebjulliand sebjulliand deleted the feature/actionRefresh branch November 18, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Action option to force filter refresh
3 participants