Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deletion current directory and check error #1658

Merged
merged 3 commits into from
Nov 18, 2023

Conversation

sebjulliand
Copy link
Collaborator

Changes

Fixes #1631
When running the Delete Object action from the IFS browser, if the target was the current directory (i.e. config.homeDirectory) the command would fail and show a success message.

This PR fixes this issue by:

  • Setting config.homeDirectory to $HOME.
  • Showing a notification about the working directory being changed.
  • Show stderr if the rm command fails.

To reproduce the initial issue:

  • Create a directory
  • Set it as the Working Directory (right click action from the IFS Browser)
  • Try to delete it

Checklist

  • have tested my change

Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
@sebjulliand
Copy link
Collaborator Author

@chrjorgensen : there is a new Danish translation waiting for you. Thanks in advance!

Copy link
Collaborator

@chrjorgensen chrjorgensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sebjulliand Working as expected - of course! 😃

Now it also throws an error if the delete operation fails:

image

@chrjorgensen chrjorgensen merged commit fc87c42 into master Nov 18, 2023
1 check passed
@sebjulliand sebjulliand deleted the fix/deleteCurrentDirectory branch November 18, 2023 22:48
@sebjulliand
Copy link
Collaborator Author

Thanks @chrjorgensen !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot delete a directory if is the Workspace Deploy Location
2 participants