Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/multilibfilter #2407

Merged
merged 3 commits into from
Dec 8, 2024
Merged

Fix/multilibfilter #2407

merged 3 commits into from
Dec 8, 2024

Conversation

sebjulliand
Copy link
Collaborator

Changes

Fixes #2405

Setting multiple libraries in a filter would result in the filter showing nothing when expanded.
image

Each library name filter must be treated independently; this PR changes the getLibraries method to perform a call to getObjectList for each library name filter.

How to test this PR

  1. Create a filter with multiple library filter names
  2. Run the Content API tests

Checklist

  • have tested my change
  • have created one or more test cases

Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
@sebjulliand sebjulliand added the bug A confirmed issue when something isn't working as intended label Dec 7, 2024
@sebjulliand sebjulliand self-assigned this Dec 7, 2024
Copy link
Contributor

github-actions bot commented Dec 7, 2024

👋 A new build is available for this PR based on 4e568b0.

Copy link
Collaborator

@chrjorgensen chrjorgensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sebjulliand LGTM - merge at will... 👍

@worksofliam worksofliam merged commit e2074b0 into master Dec 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A confirmed issue when something isn't working as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filters with multiple libraries broken
3 participants