Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MongoDB] Fixes local Docker setup and load_data script #13

Merged
merged 3 commits into from
Dec 12, 2023
Merged

[MongoDB] Fixes local Docker setup and load_data script #13

merged 3 commits into from
Dec 12, 2023

Conversation

tianjing-li
Copy link
Collaborator

@tianjing-li tianjing-li commented Dec 7, 2023 •
edited
Loading

What's being changed:

Resolves #12

  • Fixes docker compose, updates version and use connection string when loading data to emulate actual connector

How did you test this change (include any code snippets, API requests, screenshots, or gifs):

  • Tested script locally

@CLAassistant
Copy link

CLAassistant commented Dec 7, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@tianjing-li tianjing-li requested a review from a team as a code owner December 7, 2023 18:26
walterbm-cohere
walterbm-cohere approved these changes Dec 12, 2023
View reviewed changes
Copy link
Collaborator

@walterbm-cohere walterbm-cohere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for making these fixes!

@tianjing-li tianjing-li merged commit ee28963 into main Dec 12, 2023
2 checks passed
@tianjing-li tianjing-li deleted the mongodb branch December 12, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walterbm-cohere walterbm-cohere walterbm-cohere approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wrong credentials data loader in mongodb connector
3 participants
@tianjing-li @CLAassistant @walterbm-cohere