-
-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix semver not fully covered #1081
base: master
Are you sure you want to change the base?
Conversation
Currently, only test cases are added. Will need to find some time to wrap it up. Feel free to take over if anyone's interested in it 🙂 |
I think this one would be a bit tricky 🤔 prerelease can be anything for semver. Thus, bump prerelease might not make sense to semver. e.g., what should be the next version of |
I completely missed this. I don't know the answer, but I think we could stick to adding the
Similar to semver:
And we could assume anything unknown is before alpha (?) |
Sounds like a good idea 🤔 I'll get back to this one when I have more bandwidth |
Perhaps this could be done by having the user configure a prerelease word list and bump to the next item in the list. If the current prerelease is already the last word, upgrade the previous patch version. e.g.: with prerelease config:
no prerelease config:
|
Sounds like a valid idea 👀 |
@@ -64,6 +64,7 @@ | |||
(("1.0.0alpha1", None, "alpha", 0, None), "1.0.0-a2"), | |||
(("1", None, "rc", 0, None), "1.0.0-rc0"), | |||
(("1.0.0rc1+e20d7b57f3eb", "PATCH", None, 0, None), "1.0.0"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not semver but PEP440
Description
1.0.0-reallyweird
is a valid semver but not yet covered by commitizen. Possible solution could be #950 (comment)Closes: #950
Checklist
./scripts/format
and./scripts/test
locally to ensure this change passes linter check and testExpected behavior
Steps to Test This Pull Request
Additional context