Fix #5212: removing bug causing progress dialog to load forever #5350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-raoul
requested changes
Oct 19, 2023
| @@ -505,6 +505,7 @@ private void onMediaRefreshed(Media media) { | |||
| .subscribe(this::onDepictionsLoaded, Timber::e) | |||
| ); | |||
| // compositeDisposable.add(disposable); | |||
|
|
|||
There was a problem hiding this comment.
Any particular reason for this change? If not, would you mind removing the new line?
There was a problem hiding this comment.
I just added it by accident. I have removed it. Thank you!
| @@ -224,9 +224,9 @@ class DepictsPresenter @Inject constructor( | |||
| Timber.e( | |||
| "Failed to update depictions" | |||
| ) | |||
|
|
|||
nicolas-raoul
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
Tested on several pictures, it works great!
https://commons.wikimedia.org/w/index.php?title=File:Ikuchijima_211.jpg&diff=prev&oldid=812977952
Source code looks good too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5212
Description:
The bug originates from the updateDepictions function, which manages depiction updates and observes the result with both success and error handlers. While it does initiate the depiction update in the databases, the subsequent call to the showNotification function leads to an error. This issue arises because API levels 31 and above require a more specific flag for pending intents.
Changes:
Introduced an if statement to assess the current API version. If the API version exceeds 31, the flag is set to immutable.
Testing:
Verified on API levels 28 and 33 without any issues.