Fixed Grey empty screen at Upload wizard #5356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # app/src/main/java/fr/free/nrw/commons/utils/PermissionUtils.java
nicolas-raoul
requested changes
Oct 21, 2023
app/src/main/java/fr/free/nrw/commons/upload/UploadActivity.java
Outdated
Show resolved
Hide resolved
|
@nicolas-raoul, I have made all the requested changes, Can you please review them |
nicolas-raoul
requested changes
Nov 1, 2023
app/src/main/java/fr/free/nrw/commons/upload/UploadActivity.java
Outdated
Show resolved
Hide resolved
|
Merged, thanks a lot Kanahia for your pull request! :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5330
What changes did you make and why?
➕ Added functionality to the cancel button of the dialog box, because people often don't see or read everything on the screen. Therefore, we must warn them with a toast message in case they click on the cancel button and also inform them that they need to accept permissions in order to access the upload facility.
🐛 Fixed grey empty screen at upload caption step
🐛 Fixed loop created by calling permissions
onResumeTests performed (required)
Tested betaDebug on Pixel 2 with API level 29.
Screenshots (for UI changes only)
https://github.com/commons-app/apps-android-commons/assets/114223204/ac558d34-d1f2-4d4a-8078-335ca774124d
https://github.com/commons-app/apps-android-commons/assets/114223204/14abe656-7c28-4d19-bedc-1f5203ba4835
https://github.com/commons-app/apps-android-commons/assets/114223204/54b03962-0056-41d0-bdd7-a81d6eb37a55