Replaced campaignPreference with CAMPAIGNS_DEFAULT_PREFERENCE #5357
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the bug "Swiping campaign notification shows 'You won't see campaigns anymore', but actually same notification comes back after a few days."
Fixes #5288
What changes did you make and why?
I replaced the variable campaignPreference with CAMPAIGNS_DEFAULT_PREFERENCE.
In the ContributionsFragment class, the function fetchCampaigns() checks the CAMPAIGNS_DEFAULT_PREFERENCE if it is True. However, in the CampaignView class, it switches campaignPreference to False without updating the default preference after swiping.
apps-android-commons/app/src/main/java/fr/free/nrw/commons/contributions/ContributionsFragment.java
Line 591 in 1490710
apps-android-commons/app/src/main/java/fr/free/nrw/commons/campaigns/CampaignView.java
Line 72 in 1490710
Tested {} on {emulator 32.1.12-9751036} with API level {API Tiramisu}.
Screenshots (for UI changes only)
Need help? See https://support.google.com/android/answer/9075928
Note: Please ensure that you have read CONTRIBUTING.md if this is your first pull request.