Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor usage of Html.fromHtml to handle deprecation #6002 #6074

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

sonalyadav1
Copy link
Contributor

Description:

This PR refactors the usage of Html.fromHtml across the project to address the deprecation warning and replace it with HtmlCompat.fromHtml for compatibility across all Android API levels.

Changes:

Replaced deprecated Html.fromHtml with HtmlCompat.fromHtml in multiple files:
StringUtil.kt
NearbyParentFragment.java
FeedbackDialog.kt
ReviewImageFragment.kt

Why:

The Html.fromHtml method has been deprecated, and we aim to ensure compatibility with newer Android versions by using HtmlCompat.fromHtml.

Fixes: #6002

Testing:

Ensure the Html.fromHtml functionality is working correctly after the refactor.

Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK, and the app behaves correctly as far as I checked.
Thanks!

@nicolas-raoul nicolas-raoul merged commit e7864ac into commons-app:main Dec 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants