[WIP/Don't Merge] Migrated Profile from Rxjava to Retroift & added MVVM Architecture (part 1)

[neeldoshii]

Part of:

• Parent : Migrate Profile to Jetpack Compose #6063 (Part 1)

Description:

The following PR focuses on removing the RxJava usage for Achievement Screen, split the code into a MVVM pattern, cleaned the code and also fixed the flow of the AchievementScreen.

Also, there seems to be an improvement in the loading time of the achievements by some seconds (probably 1-2 seconds) compared to the main branch.

2024-12-26 20:25:54.028 loadTime                fr.free.nrw.commons                  D  The loadtime is 3318ms

[neeldoshii]

In this should I provide kdoc here? and if yes kdoc should I link the common apps API endpoint doc or provide a CURL link here?

[neeldoshii]

Hi @nicolas-raoul,
I have been trying to break Achievement Fragment for a while on main.

• As per this issue Ultimate achievement: Too many contributions (making our script time out) #3295, Ultimate achievement: Too many contributions (making our script time out) #3295 (comment) says that we should check the editcount using this api (https://commons.wikimedia.org/w/api.php?action=query&list=users&usprop=editcount&ususers=Syced&format=json) of the user if its greater than 1,50,000 we should say that we have so many achievements you unlocked Ultimate Achievements. But in the below code we are checking the editcount using this api (https://commons-android-app.toolforge.org/tool-commons-android-app/wikidataedits.py?user=Syced).

apps-android-commons/app/src/main/java/fr/free/nrw/commons/profile/achievements/AchievementsFragment.kt

Lines 152 to 176 in 22238f5

	compositeDisposable.add(
	okHttpJsonApiClient
	.getAchievements(userName ?: return)
	.subscribeOn(Schedulers.io())
	.observeOn(AndroidSchedulers.mainThread())
	.subscribe(
	{ response ->
	if (response != null) {
	setUploadCount(Achievements.from(response))
	} else {
	Timber.d("Success")
	// TODO Create a Method to Hide all the Statistics
	// binding.layoutImageReverts.visibility = View.INVISIBLE
	// binding.achievementBadgeImage.visibility = View.INVISIBLE
	// If the number of edits made by the user are more than 150,000
	// in some cases such high number of wiki edit counts cause the
	// achievements calculator to fail in some cases, for more details
	// refer Issue: #3295
	if (numberOfEdits <= 150_000) {
	showSnackBarWithRetry(false)
	} else {
	showSnackBarWithRetry(true)
	}
	}
	},

My Question :

1. Difference between the editcount received from both the api (https://commons.wikimedia.org/w/api.php?action=query&list=users&usprop=editcount&ususers=Syced&format=json) & ((https://commons-android-app.toolforge.org/tool-commons-android-app/wikidataedits.py?user=Syced)

2. I have hardcoded my username to your username(Syced) to test achievement with a high upload profile. Despite your edit count having less than 150000 server times out at your username (https://tools.wmflabs.org/commons-android-app/tool-commons-android-app/feedback.py?user=Syced) why is that? what should be the ideal editcount for our server to be able to handle it?