Github action to check metadata lines in scripts. #1110
+55
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
maintenance
7 tasks
MickLesk
previously approved these changes
Dec 30, 2024
michelroegl-brunner
requested changes
Dec 30, 2024
michelroegl-brunner
previously approved these changes
Dec 30, 2024
se-bastiaan
reviewed
Dec 30, 2024
Comment on lines
+28
to
+40
| if sed -n '4p' "$FILE" | grep -qE "^# Author: .+"; then | ||
| echo "Check for Author metadata passed for line 4 in: $FILE" | ||
| else | ||
| echo "Error in $FILE: Author metadata missing or invalid on line 4" | ||
| ERROR_COUNT=$((ERROR_COUNT + 1)) | ||
| fi | ||
|
|
||
| if [[ "$(sed -n '5p' "$FILE")" == "# License: MIT | https://github.com/community-scripts/ProxmoxVE/raw/main/LICENSE" ]]; then | ||
| echo "Check for License metadata passed for line 5 in: $FILE" | ||
| else | ||
| echo "Error in $FILE: License metadata missing or not on line 5" | ||
| ERROR_COUNT=$((ERROR_COUNT + 1)) | ||
| fi |
There was a problem hiding this comment.
Does this work with one or multiple co-authors?
There was a problem hiding this comment.
I don't completely understand how this is resolved.
Co-authored-by: Sébastiaan <se_bastiaan@outlook.com>
Co-authored-by: Sébastiaan <se_bastiaan@outlook.com>
MickLesk
approved these changes
Jan 1, 2025
michelroegl-brunner
approved these changes
Jan 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Description
Github action to check the following:
Check if it exists in line 3
Check if it exists in line 4 & that it has text after the space
Check if it exists in line 5
Check if it exists in line 6 & that it has text after the space
Please remove unneeded lines!
🛠️ Type of Change
Please check the relevant options:
✅ Prerequisites
The following steps must be completed for the pull request to be considered:
📋 Additional Information (optional)
Provide any extra context or screenshots about the feature or fix here.