Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #1178: Firefly III script will fetch only stable releases #1180

Conversation

alberanid
Copy link
Contributor

✍️ Description

Fetch only stable releases of Firefly III



🛠️ Type of Change

Please check the relevant options:

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts)

✅ Prerequisites

The following steps must be completed for the pull request to be considered:

  • Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.)
  • Testing performed (I have thoroughly tested my changes and verified expected functionality.)
  • Documentation updated (I have updated any relevant documentation)

@alberanid alberanid requested a review from a team as a code owner January 2, 2025 16:12
@github-actions github-actions bot added the update script A change that updates a script label Jan 2, 2025
Copy link
Contributor

@se-bastiaan se-bastiaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to make sure that no development version is installed on first run then https://github.com/community-scripts/ProxmoxVE/blob/main/install/firefly-install.sh#L49 should also be changed.

@MickLesk
Copy link
Member

MickLesk commented Jan 2, 2025

Its an official marked Release. Basically, it's not our problem that they maintain their versions like this. I wouldn't allow any PR here, because in a few weeks at the latest, the unnecessary PR will be back again.

@alberanid
Copy link
Contributor Author

If we want to make sure that no development version is installed on first run then https://github.com/community-scripts/ProxmoxVE/blob/main/install/firefly-install.sh#L49 should also be changed.

thanks; I've updated the PR just in case.

@MickLesk
Copy link
Member

MickLesk commented Jan 2, 2025

Fixed by Firefly Maintainer 👍

@MickLesk MickLesk closed this Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update script A change that updates a script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants