COMCL-887: Support renewal of paid contribution #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@olayiwola-compucorp could you explain the technical details in a bit more detail please? I'm a little confused as to what changed in 3.x -> 4.x in order for this to become a problem? Doe the fact that completing the contribution "doesn't change the end of a recurring contribution" have other knock on effects? |
shahrukh-compuco
approved these changes
Oct 24, 2024
No it doesn't have any other effects. |
olayiwola-compucorp
deleted the
COMCL-887-renew-completed-contribution
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Before this PR membership with paid contributions did not get renewed, this is because of a recurring contribution condition that filters out recurring contributions with non-empty end date
Before
Membership did not get renewed, and no new contribution was created after running the renewal job
After
Running the renewal job now renews the membership with a completed contribution and creates a new pending contribution
Technical Details
This issue didn't happen in the previous CiviCRM version because completing a contribution does not change the end date of the recurring contribution.