Fix next after close

compulim · Jun 8, 2024 · 9fa4ffa · 9fa4ffa
1 parent 4c7d82a
commit 9fa4ffa
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/packages/iter-fest/src/PushAsyncIterableIterator.spec.ts b/packages/iter-fest/src/PushAsyncIterableIterator.spec.ts
@@ -41,3 +41,13 @@ describe('comprehensive', () => {
     test('should completed the for-loop', () => expect(done).toHaveBeenCalledTimes(1));
   });
 });
+
+test('push after close should close the iterable', async () => {
+  const iterable = new PushAsyncIterableIterator();
+
+  iterable.close();
+  await expect(iterable.next()).resolves.toEqual({ done: true, value: undefined });
+
+  iterable.push(1);
+  await expect(iterable.next()).resolves.toEqual({ done: true, value: undefined });
+});
diff --git a/packages/iter-fest/src/PushAsyncIterableIterator.ts b/packages/iter-fest/src/PushAsyncIterableIterator.ts
@@ -3,13 +3,15 @@ import withResolvers from './private/withResolvers';
 const CLOSE = Symbol('close');
 
 export class PushAsyncIterableIterator<T> implements AsyncIterableIterator<T> {
+  #closed: boolean = false;
   #pushResolvers: PromiseWithResolvers<T | typeof CLOSE> = withResolvers();
 
   [Symbol.asyncIterator]() {
     return this;
   }
 
   close() {
+    this.#closed = true;
     this.#pushResolvers.resolve(CLOSE);
   }
 
@@ -24,7 +26,9 @@ export class PushAsyncIterableIterator<T> implements AsyncIterableIterator<T> {
   }
 
   push(value: T) {
-    this.#pushResolvers.resolve(value);
-    this.#pushResolvers = withResolvers();
+    if (!this.#closed) {
+      this.#pushResolvers.resolve(value);
+      this.#pushResolvers = withResolvers();
+    }
   }
 }