Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix path under Node.js ESM #37

Merged
merged 3 commits into from
Jun 29, 2024
Merged

Fix path under Node.js ESM #37

merged 3 commits into from
Jun 29, 2024

Conversation

compulim
Copy link
Owner

@compulim compulim commented Jun 29, 2024 •
edited
Loading

Changelog

Please copy and paste new entries from CHANGELOG.md here.

Fixed

  • Fixed ESM imports under Node.js, in PR #37

Specific changes

Please list each individual specific change in this pull request.

  • Updated all imports to include .js for import via filenames
  • Moved from Jest to mocha for packages/integration-test to catch import errors

@compulim compulim marked this pull request as ready for review June 29, 2024 08:05
@compulim compulim merged commit 25af1d2 into main Jun 29, 2024
5 checks passed
@compulim compulim deleted the fix-esm branch June 29, 2024 08:08
@compulim compulim mentioned this pull request Jun 29, 2024
Merged
@compulim-workflow-bot compulim-workflow-bot bot mentioned this pull request Oct 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@compulim