Skip to content
This repository has been archived by the owner on Dec 23, 2024. It is now read-only.

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This PR has been triggered in an effort to update pypy38.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/2737257355, please use this URL for debugging.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@twiecki
Copy link
Contributor

twiecki commented Jul 26, 2022

@maresb I'm scared of pypy now is this safe to merge?

@maresb
Copy link
Contributor

maresb commented Jul 26, 2022

I'm not in any particular hurry to see this merged. We could sit on it for a while until a day where we feel particularly adventurous.

The current situation of having been stuck for so long on pypy37 was mainly due to conda-forge/scipy-feedstock#204 taking two months. Hopefully now BLAS will now have full proper support.

But then the only annoying thing about 3.7 was that BLAS wasn't loading properly. If someone's adventurous enough to try PyPy they're likely also capable of troubleshooting BLAS issues.

As for the recipe itself, I wrote it well so that it would be ready for this update! 😄

But now that pypy37 is officially gone, I can remove the corresponding selectors, simplifying the recipe...

@maresb
Copy link
Contributor

maresb commented Jul 26, 2022

Let's please close this in favor of #99.

@ericmjl ericmjl closed this Jul 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants