Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use pathlib #1948

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions bootstrap-obvious-ci-and-miniconda.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,9 @@

"""
import argparse
import os
from pathlib import Path
import platform
import subprocess
import sys

try:
from urllib.request import urlretrieve
Expand Down Expand Up @@ -85,22 +84,22 @@ def main(
else:
raise ValueError("Unsupported operating system.")

if not os.path.exists(basename):
if not Path(basename).exists():
print("Downloading from {}".format(URL))
urlretrieve(URL, basename)
else:
print("Using cached version of {}".format(URL))

# Install with powershell.
if os.path.exists(target_dir):
if Path(target_dir).exists():
raise IOError("Installation directory already exists")
subprocess.check_call(cmd)

if not os.path.isdir(target_dir):
if not Path(target_dir).is_dir():
raise RuntimeError("Failed to install miniconda :(")

if install_obvci:
conda_path = os.path.join(target_dir, bin_dir, "conda")
conda_path = Path(target_dir, bin_dir, "conda")
subprocess.check_call(
Comment on lines 93 to 103
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why we are using several Path instantiations here when it's all target_dir. We should have something like:

target_dir = Path(target_dir)
if target_dir.exists():
  ...
if not target_dir.is_dir():
  ...
if install_obvci:
  conda_path = target_dir / bin_dir / "conda"

and so on. I'm afraid this happens in more areas of the PR, so a careful review is advised imo.

[
conda_path,
Expand Down
3 changes: 2 additions & 1 deletion conda_smithy/azure_ci_utils.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import os
from pathlib import Path
import typing
import warnings

Expand Down Expand Up @@ -41,7 +42,7 @@ def __init__(

try:
with open(
os.path.expanduser("~/.conda-smithy/azure.token"), "r"
Copy link
Member

@wolfv wolfv Jul 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about Path("~/.conda-smithy/azure.token").expanduser().read_text().strip()?

Path("~/.conda-smithy/azure.token").expanduser(), "r"
) as fh:
self.token = fh.read().strip()
if not self.token:
Expand Down