Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CF_DPCPP_ENABLED #2133

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ZzEeKkAa
Copy link

@ZzEeKkAa ZzEeKkAa commented Nov 12, 2024

Checklist

  • Added a news entry
  • Regenerated schema JSON if schema altered (python conda_smithy/schema.py)

Addresses #2129 issue. Will be resolve after merging this PR and updating https://github.com/conda-forge/conda-forge-pinning-feedstock/blob/main/recipe/conda_build_config.yaml

@ZzEeKkAa ZzEeKkAa requested a review from a team as a code owner November 12, 2024 19:34
@isuruf
Copy link
Member

isuruf commented Nov 12, 2024

I'm not sure why this is needed. Can you explain?

@ZzEeKkAa
Copy link
Author

@isuruf as I described in #2129, I'm trying to add dpcpp compiler option to pytorch build. However I'm facing problems with zip_keys, so I'm trying to do something like this:
https://github.com/conda-forge/conda-forge-pinning-feedstock/pull/6686/files

I was using cuda as an example. I guess reason for the CF_(CUDA|DPCPP)_ENABLED is to disable generation of compiler specific options if they are not in use.

I'm open to other solutions of the original issue, but this is the only solution I can see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants