Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to parse when body includes something that looks like a scope with new line #48

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Otard95
Copy link

@Otard95 Otard95 commented Mar 18, 2024

I originally came across this when release-please didn't pick up one of our commits. Eventually I tracked it down to this package. I'm creating a PR, mostly to provide the failing test showing the issue. I minimized the test as much as possible, here's a snippet of the original text from the commit that failed to parse, if that's helpful:

    ```graphql
@​link(url: "https://specs.apollo.dev/federation/v2.6", import:
[..., "@​policy"])
    ```

The code block is a result of the text in this PR apollographql/federation#2818 ending up in one of our Renovate PR's and subsequently commit body.

@Otard95 Otard95 changed the title Fails to parse when body includes something that looks like a scope Fails to parse when body includes something that looks like a scope with new line Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant