Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HUGE WIP] New Magic #4127

Draft
wants to merge 12 commits into
base: next
Choose a base branch
from
Draft

Conversation

peaklabs-dev
Copy link
Member

@peaklabs-dev peaklabs-dev commented Nov 4, 2024

Changes

  • TODO: Move everything into dedicated Bootstrap helpers (only the global needed stuff)
  • TODO: The rest of the functions should be moved into Application specific helpers like app/Helpers/SshMultiplexingHelper.php and also inside folders so we can better unit test stuff. Example: app>helpers>parsers> Then all parser files like compose, volume, dockerfile parsers...

Issues (will be fixed with this PR - wip)

@weeblr
Copy link

weeblr commented Nov 9, 2024

Hello,

Can you have a look at https://discord.com/channels/459365938081431553/1304467966582063164

Behavior does not seem expected and is related to parsing of env variables in docker-compose file.

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants