Skip to content
This repository has been archived by the owner on Oct 24, 2024. It is now read-only.

ADCIO-3300) refactor: applied pnpm #43

Merged
merged 11 commits into from
Apr 22, 2024
Merged

Conversation

neverlish
Copy link
Collaborator

@neverlish neverlish commented Apr 22, 2024

โœ… Jira Ticket Number

ADCIO-3300
ADCIO-3274

๐Ÿ’ก Proposed solution

  • ํŒจํ‚ค์ง€๋งค๋‹ˆ์ € ๋ณ€๊ฒฝ(yarn -> pnpm)
  • pnpm workspace ๋„์ž…
  • src ํด๋”๋ฅผ packages ๋กœ ์ด๋™
  • @adcio.js/core / @adcio.js/api / @adcio.js/lib ํŒจํ‚ค์ง€ํ™”

๐Ÿ“š TODO

  • ์ถ”ํ›„ ๋ณ„๋„ ์ž‘์—… ์˜ˆ์ •
    • demo, mock, tests ํด๋”๋ฅผ ๋ชจ์•„ dev ํด๋”๋กœ ์ด๊ด€
    • @adcio.js/core ๋ฅผ ๋ณ„๋„๋กœ ํผ๋ธ”๋ฆฌ์‹œ ํ•  ์ˆ˜ ์žˆ๋Š” ํŒŒ์ดํ”„๋ผ์ธ ๊ตฌ์ถ•

@neverlish neverlish requested review from dev-redo and hanchchch April 22, 2024 08:57
@neverlish neverlish changed the title Refactor/pnpm adcio 3300 ADCIO-3300) refactor: applied pnpm Apr 22, 2024
@neverlish neverlish self-assigned this Apr 22, 2024
@neverlish neverlish merged commit 9d911a1 into develop Apr 22, 2024
1 check passed
@neverlish neverlish deleted the refactor/pnpm-ADCIO-3300 branch April 22, 2024 09:59
Copy link
Contributor

@dev-redo dev-redo Apr 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ํ˜น์‹œ... ์•„๋ž˜ ์˜ต์…˜๋“ค์„ ์ถ”๊ฐ€ํ•˜๋Š” ๊ฒƒ์€ ์–ด๋–ป๊ฒŒ ์ƒ๊ฐํ•˜์‹ค๊นŒ์š”? ๐Ÿ‘€

packageManager๋ฅผ ์„ค์ •ํ•˜๋ฉด ๋กœ์ปฌ์—์„œ pnpm์„ ์„ค์น˜ํ•˜์ง€ ์•Š์•„๋„ corepack enabled๋ฅผ ํ†ตํ•ด pnpm์„ ์ด์šฉํ•  ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค.

"packageManager": "pnpm@์‚ฌ์šฉํ•˜๋Š” ๋ฒ„์ „ ๋ช…์‹œ", // pnpm ๋ฒ„์ „ ๋ช…์‹œ
"engineStrict": true, // ํŒจํ‚ค์ง€ ๋งค๋‹ˆ์ € ๋ฒ„์ „๊ณผ ๋™์ผํ•˜์ง€ ์•Š์œผ๋ฉด ์—๋Ÿฌ๋ฅผ ๋„์›€
"engines": { 
  "node": "์‚ฌ์šฉํ•˜๋Š” ๋ฒ„์ „ ๋ช…์‹œ",
  "yarn": "please-use-pnpm", // pnpm์ด ์•„๋‹Œ ๋‹ค๋ฅธ ํŒจํ‚ค์ง€๋งค๋‹ˆ์ €๋ฅผ ์‚ฌ์šฉํ•  ๊ฒฝ์šฐ ์—๋Ÿฌ
  "npm": "please-use-pnpm",
  "pnpm": "์‚ฌ์šฉํ•˜๋Š” ๋ฒ„์ „ ๋ช…์‹œ"
},

์ฐธ๊ณ ํ–ˆ๋˜ ๋งํฌ: https://beomy.github.io/tech/etc/package-json/

@@ -15,29 +15,23 @@ jobs:
with:
node-version: 18

- run: npm install -g pnpm
Copy link
Contributor

@dev-redo dev-redo Apr 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package.json์— packageManager๋ฅผ ์ด์šฉํ•ด ๋ฒ„์ „์„ ๋ช…์‹œํ•œ๋‹ค๋ฉด

corepack์„ ์ด์šฉํ•ด์„œ pnpm์„ ์„ค์น˜ํ•ด๋„ ๊ดœ์ฐฎ๊ฒ ๋‹ค๋Š” ์ƒ๊ฐ์„ ํ–ˆ์–ด์š”...

๊ด€๋ จ ๋งํฌ: actions/setup-node#480 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants