Merge pull request #45 from coveo/remove-bad-characters-from-tags

Remove potentially bad characters from docker tags

config.go

@@ -104,10 +104,12 @@ func (cb TGFConfigBuild) Dir() string {
 
 // GetTag returns the tag name that should be added to the image
 func (cb TGFConfigBuild) GetTag() string {
+	tag := filepath.Base(filepath.Dir(cb.source))
 	if cb.Tag != "" {
-		return cb.Tag
+		tag = cb.Tag
 	}
-	return filepath.Base(filepath.Dir(cb.source))
+	tagRegex := regexp.MustCompile(`[^a-zA-Z0-9\._-]`)
+	return tagRegex.ReplaceAllString(tag, "")
 }
 
 // InitConfig returns a properly initialized TGF configuration struct

config_test.go

@@ -116,6 +116,30 @@ func TestSetConfigDefaultValues(t *testing.T) {
 	assert.Nil(t, config.ImageVersion)
 }
 
+func TestWeirdDirName(t *testing.T) {
+	tempDir, _ := ioutil.TempDir("", "bad@(){}-good-_.1234567890ABC")
+	currentDir, _ := os.Getwd()
+	os.Chdir(tempDir)
+	fmt.Println(tempDir)
+	defer func() {
+		os.Chdir(currentDir)
+		os.RemoveAll(tempDir)
+	}()
+	testSSMParameterFolder := fmt.Sprintf("/test/tgf-%v", randInt())
+	testTgfConfigFile := fmt.Sprintf("%s/.tgf.config", tempDir)
+	tgfConfig := []byte(String(`
+		docker-image: coveo/stuff
+		docker-image-build: RUN ls test2
+		docker-image-build-folder: my-folder
+	`).UnIndent().TrimSpace())
+	ioutil.WriteFile(testTgfConfigFile, tgfConfig, 0644)
+
+	config := InitConfig()
+	config.setDefaultValues(testSSMParameterFolder)
+
+	assert.True(t, strings.HasPrefix(config.imageBuildConfigs[0].GetTag(), "bad-good-_.1234567890ABC"))
+}
+
 func TestParseAliases(t *testing.T) {
 	t.Parallel()