Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: prevent device/address change when linked to CMDB #46

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

kpetremann
Copy link
Contributor

Some CMDB models are linked to NetBox DCIM/IPAM native models.
If we change the address of an IPAddress object, it will change the value for the CMDB too. It could lead to unwanted side effect.
This PR fixes by adding a decorator to protect the CMDB from that.

@kpetremann kpetremann requested review from a team October 16, 2024 16:18
@kpetremann kpetremann force-pushed the dcim_change_protection branch from 2d72a08 to 493f08a Compare October 17, 2024 09:24
@kpetremann kpetremann force-pushed the dcim_change_protection branch from c6995f1 to 8ea40dc Compare October 21, 2024 13:03
@kpetremann kpetremann merged commit 75273f1 into criteo:main Oct 22, 2024
2 checks passed
@kpetremann kpetremann deleted the dcim_change_protection branch October 22, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants