Merge #930

930: Fix `is_verbose` accepting any 1-character argument. r=Emilgardis a=Alexhuszagh



Co-authored-by: Alex Huszagh <ahuszagh@gmail.com>

CHANGELOG.md

@@ -7,6 +7,10 @@ This project adheres to [Semantic Versioning](http://semver.org/).
 
 ## [Unreleased] - ReleaseDate
 
+## Fixed
+
+- #930 - fix any parsing of 1-character subcommands
+
 ## [v0.2.3] - 2022-07-09
 
 ### Added

src/cli.rs

@@ -72,10 +72,13 @@ fn is_verbose(arg: &str) -> bool {
     match arg {
         "--verbose" => true,
         // cargo can handle any number of "v"s
-        a => a
-            .get(1..)
-            .map(|a| a.chars().all(|x| x == 'v'))
-            .unwrap_or_default(),
+        a => {
+            a.starts_with('-')
+                && a.len() >= 2
+                && a.get(1..)
+                    .map(|a| a.chars().all(|x| x == 'v'))
+                    .unwrap_or_default()
+        }
     }
 }
 
@@ -238,3 +241,20 @@ pub fn parse(target_list: &TargetList) -> Result<Args> {
         color,
     })
 }
+
+#[cfg(test)]
+mod tests {
+    use super::*;
+
+    #[test]
+    fn is_verbose_test() {
+        assert!(!is_verbose("b"));
+        assert!(!is_verbose("x"));
+        assert!(!is_verbose("-"));
+        assert!(!is_verbose("-V"));
+        assert!(is_verbose("-v"));
+        assert!(is_verbose("--verbose"));
+        assert!(is_verbose("-vvvv"));
+        assert!(!is_verbose("-version"));
+    }
+}