Add CSV.parse - Support Headers #15258
Open
+79
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zeljko-Predjeskovic
changed the title
RX14
reviewed
Dec 9, 2024
| @@ -19,6 +19,16 @@ class CSV::Parser | |||
| rows | |||
| end | |||
|
|
|||
| def parse_to_h : Array(Hash(String, String)) | |||
There was a problem hiding this comment.
realizing that this is not a good place since it parses the remaining rows and that means that every row could be the headers. Didnt notice since i tested only CSV and not the parser itself. Either when using this methode, rewind the parser to the begining or somehow extract the header.
There was a problem hiding this comment.
I'm a bit dubious about rewinding to get the headers. I think the caller can make sure the CSV parser is where it needs to be before calling to_h.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on issue #15170 requirements and solution recommendations.
closes #15170, if this PR is accepted and merged.