Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increased Zoom level and added AutoSave and Backup in PabloDraw.Console #19

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

DavStas
Copy link

@DavStas DavStas commented Jun 14, 2018

  • Pablo: Increased zoom level to 700% when editing in textmode and in rip
  • PabloDraw.Console: Added AutoSave and Backup

DavStas added 2 commits June 14, 2018 19:32
…textmode as rip mode

- PabloDraw.Console: Added AutoSave and Backup functionalities
… rip

- PabloDraw.Console: Added AutoSave and Backup
@christianvozar
Copy link

@cwensley Some features to review and possibly merge into master. I have been running the macOS build of this and the features work as explained (+1)

@cwensley
Copy link
Owner

cwensley commented Jun 14, 2018

First of all, thanks a ton for helping improve PabloDraw! This is excellent!

I think with the autosave it can only save to ".ans" or ".rip" and the Document.Info.DefaultFormat is not guaranteed to be RIP format. Also, what if they want to save as .xb, or some other format?

What might make sense here is to simply save the document to the file name provided in the command line via Document.FileName. If the file name isn't provided, then you could use a sensible default (like "AutoSave" as you have already done) using the extension from Document.Format.Extensions[0].

Also something to consider, is the Timer will be running in a different thread as the server, so saving using that thread might cause an exception as I think it's accessing non-thread safe objects. Not sure what would need to be done to allow for that, but something to think about.

Thanks again!

Base automatically changed from master to main January 30, 2021 19:50
@Kirkman
Copy link

Kirkman commented Feb 18, 2023

Hi @cwensley, would you consider incorporating the increased zoom level support from this pull request, for drawing RIP?

Like @christianvozar in issue #17, I find it really difficult to draw pixel art when the zoom is limited to a maximum of 200%. Much higher zooms, maybe up to 800%, would be so useful.

@cwensley
Copy link
Owner

@Kirkman absolutely, though have you tried the "Expand to Fit" option? It stretches the canvas to the width of the window.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants