Merge pull request #146 from thenotsoft/fix_embedded_relational_mapping

fix embedded relation unmapped properties
cycle · Dec 24, 2020 · 6b107e1 · 6b107e1
2 parents 60ae3bc + 39a3e31
commit 6b107e1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/Relation/Embedded.php b/src/Relation/Embedded.php
@@ -192,7 +192,7 @@ public function queue(CC $store, $entity, Node $node, $related, $original): Comm
      */
     protected function getChanges($related, State $state): array
     {
-        $data = $this->mapper->extract($related);
+        $data = array_intersect_key($this->mapper->extract($related), $this->columns);
 
         return array_udiff_assoc($data, $state->getData(), [static::class, 'compare']);
     }

diff --git a/tests/ORM/Fixtures/UserCredentials.php b/tests/ORM/Fixtures/UserCredentials.php
@@ -15,4 +15,7 @@ class UserCredentials
 {
     public $username;
     public $password;
+
+    public $unmapped_public_property;
+    private $unmapped_private_property;
 }