Fix needless returns in CloudWatch driver #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dacbd
reviewed
Sep 4, 2024
* Use explicit returns if there's a return somewhere else in the function. * Return an error if a log group couldn't be created. * Make failure to set a retention policy a warning message (was already not a hard error). * Map `SdkError` to service errors to remove some nested `match` statements.
miceg
force-pushed
the
upstream-cloudwatch-needless-returns
branch
from
9acb373 to
deae5eb
Compare
dacbd
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've got another PR with some refactoring that fixes the other needless returns.