fix(website): restore vendor prefixes and resolve hydration mismatch #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 458e69d:
|
dai-shi
approved these changes
Jan 28, 2024
Aslemammad
reviewed
Jan 28, 2024
| import theme from '../theme.json'; | ||
|
|
||
| type CodeProps = { | ||
| code: string; | ||
| }; | ||
|
|
||
| export const Code = ({ code, ...rest }: CodeProps) => ( | ||
| <BrightCode lang="tsx" theme={theme} code={code.trim()} {...rest} /> | ||
| <ClientOnly> |
There was a problem hiding this comment.
Nice, I didn't think about that since I thought the code SSR is important! But this makes sense, the code does not play a huge role.
Ideally, we'd have a PR in the bright repo itself. code-hike/bright#39
There was a problem hiding this comment.
Okay, let's hope it will be resolved upstream. Merging this for now.
Aslemammad
approved these changes
Jan 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.