Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark ColumnLayoutEngine as deprecated #985

Merged
merged 6 commits into from
Aug 20, 2024

Conversation

dalyIsaac
Copy link
Owner

@dalyIsaac dalyIsaac commented Aug 20, 2024

Marked ColumnLayoutEngine as deprecated. Added equivalent SliceLayouts.CreateRowLayout and SliceLayouts.CreateColumnLayout.

@dalyIsaac dalyIsaac added refactor The code can be simplified/moved/cleaned up core Whim labels Aug 20, 2024
@dalyIsaac dalyIsaac linked an issue Aug 20, 2024 that may be closed by this pull request
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.10%. Comparing base (8639f2a) to head (4cf93b2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #985      +/-   ##
==========================================
+ Coverage   81.09%   81.10%   +0.01%     
==========================================
  Files         274      274              
  Lines       11324    11328       +4     
  Branches     1282     1282              
==========================================
+ Hits         9183     9188       +5     
+ Misses       1969     1968       -1     
  Partials      172      172              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dalyIsaac dalyIsaac force-pushed the 810-mark-columnlayoutengine-as-obsolete branch from a897a91 to 4cf93b2 Compare August 20, 2024 11:03
@dalyIsaac dalyIsaac marked this pull request as ready for review August 20, 2024 11:07
@dalyIsaac dalyIsaac merged commit 94c48d1 into main Aug 20, 2024
8 checks passed
@dalyIsaac dalyIsaac deleted the 810-mark-columnlayoutengine-as-obsolete branch August 20, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Whim refactor The code can be simplified/moved/cleaned up
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mark ColumnLayoutEngine as obsolete
1 participant