Save model checkpoints to Wandb #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danbraunai-apollo
approved these changes
Oct 17, 2024
simple_stories_train/utils.py
Outdated
Comment on lines
40
to
41
| with open(save_dir / config_filename, "w") as f: | ||
| yaml.dump(config_dict, f) |
There was a problem hiding this comment.
This config file might exist already. I think i'd either check if this file already exists and save it if not, or just save the config earlier in the script and don't save it here. The downside of the latter is if you do lots of trial/debugging runs, you end up with lots of output directories with a config file in it but nothing else.
Also note that the docstring assumes you're doing the former.
There was a problem hiding this comment.
That makes sense, addressed! Tho I'm not sure why when I tested, the content seemed to still be correctly written (i.e. the config was not appended multiple times)
|
Just tested this, looking good and merging. Thanks @ryanhoangt! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is to:
Related Issue
Fixes #7
How Has This Been Tested?