-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major refactor (inc adding Pydantic) #16
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool, and ready for merge, with just one minor usability comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment: Since compilation is on by default (which is probably good), we might want to include --compile 0
in the example prompt for local execution, since compilation on e.g. mac gives very ugly errors that might be hard for newcomers to trace back to this flag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good pickup, added.
Description
New usage (which is also written in the README and the train_llama.py script:
where
PATH/TO/CONFIG.yaml
contains the training config. If no path is provided, a default config will be used.--key1 value1 --key2 value2 ...
override values in the config. Note that if you wish to update anested value, you must use dotted notation (e.g.
--train_dataset_config.name my_dataset
).To run on multiple GPUs, use
where
N
is the number of GPUs to use.Motivation and Context
It's currently quite hard to understand and work with the training scripts. This PR aims to set us towards a nicer library to use/contribute to.
How Has This Been Tested?
utils.convert_dotted_args_to_nested_dict
.Does this PR introduce a breaking change?
Yes. Complete override of config. Some config argument names have changed.