Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace DeviceConnectionInterface with io.ReadWriteCloser for DTX #307

Closed
wants to merge 2 commits into from

Conversation

dmissmann
Copy link
Collaborator

The DeviceConnectionInterface doesn't look like a very useful interface. Most of the service should only require a io.ReadWriteCloser to communicate with the device. And that's what kind of already happens, but since DeviceConnectionInterface exposes the io.Reader and io.Writer interfaces on separate methods, we still have to go through that instead of simply using the io.ReadWriteCloser interface directly.

For DTX the changes are very minimal, and most other services should not be more complex as most of the additional methods in DeviceConnectionInterface are either used by the debugproxy or lockdown.

@dmissmann dmissmann force-pushed the dm-dtx-remove-deviceconnecdtion branch from f8234cb to 6168efa Compare November 29, 2023 11:13
@danielpaulus
Copy link
Owner

danielpaulus commented Dec 21, 2023

The DeviceConnectionInterface doesn't look like a very useful interface. Most of the service should only require a io.ReadWriteCloser to communicate with the device. And that's what kind of already happens, but since DeviceConnectionInterface exposes the io.Reader and io.Writer interfaces on separate methods, we still have to go through that instead of simply using the io.ReadWriteCloser interface directly.

For DTX the changes are very minimal, and most other services should not be more complex as most of the additional methods in DeviceConnectionInterface are either used by the debugproxy or lockdown.

"Doesn't look very useful".. you are really hurting my feelings here @dmissmann 😭
🤣 I think the change makes sense.

If you can fix the test, we can merge this.

@dmissmann dmissmann closed this Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants