Replace DeviceConnectionInterface with io.ReadWriteCloser for DTX #307
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
DeviceConnectionInterface
doesn't look like a very useful interface. Most of the service should only require aio.ReadWriteCloser
to communicate with the device. And that's what kind of already happens, but sinceDeviceConnectionInterface
exposes theio.Reader
andio.Writer
interfaces on separate methods, we still have to go through that instead of simply using theio.ReadWriteCloser
interface directly.For DTX the changes are very minimal, and most other services should not be more complex as most of the additional methods in
DeviceConnectionInterface
are either used by the debugproxy or lockdown.