fix(Makefile): use native GOOS/GOARCH by default #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@danielpaulus that one would be nice to merge |
|
Sorry folks for the long time to merge, I was out for health reasons for quite a bit. Back now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Makefile attempts to determine the target OS/arch so that it can specify
GOOS/GOARCHexplicitly when callinggo.This doesn't really achieve anything as it ends up competing with the same default behavior of
goas well as the user's own configured environment.Furthermore, it causes the build to fail on newer Apple silicon Macs, where
uname -mreportsarm64(notaarch64expected by the Makefile).This change removes the behavior that always-overrides
GOARCH. The user can either specifyGOOSandGOARCHin the Makefile where commented, or they can simply export the variables through their environment and the Makefile will respect them.Otherwise, do not override
GOARCHorGOOSwithin the Makefile. Let thegotoolchain figure it out as intended.