Add Python 3.12 to build matrix

danijar · Sep 12, 2024 · 6770465 · 6770465
1 parent c04d078
commit 6770465
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/.github/workflows/tests.yaml b/.github/workflows/tests.yaml
@@ -5,11 +5,11 @@ on:
 jobs:
   build:
     runs-on: ubuntu-latest
-    timeout-minutes: 3
+    timeout-minutes: 5
     strategy:
       fail-fast: False
       matrix:
-        python-version: ["3.9", "3.10", "3.11"]
+        python-version: ["3.9", "3.10", "3.11", "3.12"]
     steps:
     - uses: actions/checkout@v2
     - name: Install Python

diff --git a/tests/test_client.py b/tests/test_client.py
@@ -155,14 +155,10 @@ def test_future_cleanup(self, repeat):
     server = portal.Server(port)
     server.bind('fn', lambda x: x)
     server.start(block=False)
-    client = portal.Client('localhost', port)
+    client = portal.Client('localhost', port, maxinflight=1)
     client.fn(1)
     client.fn(2)
-    # Wait for the server to respond to the first two requests, so that all
-    # futures are inside the client by the time we block on the third future.
-    time.sleep(0.1)
     future3 = client.fn(3)
-    assert len(client.futures) == 1
     assert future3.result() == 3
     del future3
     assert len(client.futures) == 0