Added the ability to pass in a custom Json RPC ID

[Luzzotica]

I needed the ability to pass in a custom RPC id.

It was easy to add, and doesn't affect the protocol's API in any way, just added functionality.

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[kevmoo]

@devoncarew – what our maintenance story on this package?

[natebosch]

Can you describe your use case?

This PR would need tests and a CHANGELOG entry, but I'd like to understand the motivation better before we accept it.

[github-actions]

Without additional information we're not able to resolve this PR. Feel free to add more info or respond to any questions above. Thanks for your contribution!

[Luzzotica]

Gosh dang! I missed your comments guys sorry!

I needed to use a JSON RPC but have complete control of the RPC IDs.

This package, without the changes I made, only allow incrementing IDs.

My JSON RPC package is WalletConnect and it sends JSON RPC requests to a relay that forwards it to subscribers.
There are thousands, maybe tens of thousands of JSON RPC requests sent to the relay and if every one used incrementing RPC IDs there would be conflicts.
Having complete control over the entropy for the RPC IDs is the only way to resolve this.

Hence my changes.

If you need more details let me know.

[natebosch]

The use case makes sense. Can you add a test and a CHANGELOG entry?

https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md#changelog-entries

[natebosch]

Looks like the CLA also needs attention.

#92 (comment)

[Luzzotica]

Just agreed to the CLA.

[natebosch]

The use case makes sense. Can you add a test and a CHANGELOG entry?

https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md#changelog-entries

I think we still need a CHANGELOG entry and a test if this is still something you'd like to see landed.

[mosuem]

Closing as the dart-lang/json_rpc_2 repository is merged into the dart-lang/tools monorepo. Please re-open this PR there!