Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PLUGIN-1832] Error Management Snowflake Source and Sink, fix sonar issues, and added new Validation and fix bugs for maximum split size and NPE issue handled #43

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[PLUGIN-1832] Error Management Snowflake Source and Sink, fix sonar issues, and added new Validation and fix bugs for maximum split size and NPE issue handled #43

wants to merge 1 commit into from
+560 −94

Conversation

Amit-CloudSufi
Copy link

@psainics psainics added the build build label Dec 18, 2024
@psainics psainics requested a review from sahusanket December 24, 2024 05:00
@sahusanket
Copy link

What is the new snowflake zip.zip ? why is this needed ?

itsankit-google
itsankit-google reviewed Jan 8, 2025
View reviewed changes
Copy link
Member

@itsankit-google itsankit-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add screenshot as evidences of response returned from error classification api in PR description.

@Amit-CloudSufi
Error management for Snowflake source and sink, Added new validation …
fcd56b5 
…for maximum split size and NPE issue handled
itsankit-google
itsankit-google reviewed Jan 9, 2025
View reviewed changes
Copy link
Member

@itsankit-google itsankit-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add evidence of testing in PR description before merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsankit-google itsankit-google itsankit-google approved these changes

@sahusanket sahusanket sahusanket left review comments

@psainics psainics Awaiting requested review from psainics

Assignees
No one assigned
Labels
build build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Amit-CloudSufi @sahusanket @itsankit-google @psainics