fix(query): return semantic error for SRFs in WHERE and HAVING clauses (

#17167)

* fix(query): raise semantic error for SRFs in WHERE and HAVING

* remove the test using flatten function

src/query/sql/src/planner/semantic/type_check.rs

@@ -2603,15 +2603,28 @@ impl<'a> TypeChecker<'a> {
         func_name: &str,
         args: &[&Expr],
     ) -> Result<Box<(ScalarExpr, DataType)>> {
-        if matches!(
-            self.bind_context.expr_context,
-            ExprContext::InSetReturningFunction
-        ) {
-            return Err(ErrorCode::SemanticError(
-                "set-returning functions cannot be nested".to_string(),
-            )
-            .set_span(span));
+        match self.bind_context.expr_context {
+            ExprContext::InSetReturningFunction => {
+                return Err(ErrorCode::SemanticError(
+                    "set-returning functions cannot be nested".to_string(),
+                )
+                .set_span(span));
+            }
+            ExprContext::WhereClause => {
+                return Err(ErrorCode::SemanticError(
+                    "set-returning functions are not allowed in WHERE clause".to_string(),
+                )
+                .set_span(span));
+            }
+            ExprContext::HavingClause => {
+                return Err(ErrorCode::SemanticError(
+                    "set-returning functions cannot be used in HAVING clause".to_string(),
+                )
+                .set_span(span));
+            }
+            _ => {}
         }
+
         if self.in_window_function {
             return Err(ErrorCode::SemanticError(
                 "set-returning functions cannot be used in window spec",

tests/sqllogictests/suites/query/functions/02_0051_function_semi_structureds_get.test

@@ -572,6 +572,12 @@ select id, json_path_query(obj, '$.b?(@.c > 2)') from t2
 statement error 1006
 select id, json_path_query(obj, '--') from t2
 
+statement error 1065
+select id from t2 where json_path_query(obj, '$.a') = 1
+
+statement error 1065
+select id from t2 having json_path_query(obj, '$.a') = 1
+
 query IT
 select id, json_path_query_array(arr, '$[2, 1 to last -1]') from t1
 ----

tests/sqllogictests/suites/query/functions/02_0062_function_unnest.test

@@ -512,6 +512,12 @@ b
 statement error 1065
 select unnest(first_value('aa') OVER (PARTITION BY 'bb'))
 
+statement error 1065
+select * from numbers(10) where unnest([1,2,3])::BOOLEAN;
+
+statement error 1065
+select * from numbers(10) having unnest([1,2,3])::BOOLEAN;
+
 statement ok
 set max_block_size = 65535;
 

tests/sqllogictests/suites/query/functions/02_0065_function_json.test

@@ -370,6 +370,12 @@ b [1,2,3]
 c true
 d {"k1":1,"k2":2}
 
+statement error 1065
+SELECT * FROM json_each(parse_json('{"a": true}')) WHERE json_each(parse_json('{"a": true}'))
+
+statement error 1065
+SELECT * FROM json_each(parse_json('{"a": true}')) HAVING json_each(parse_json('{"a": true}'))
+
 query T
 SELECT json_array_elements(NULL)
 ----
@@ -420,6 +426,12 @@ SELECT * FROM json_array_elements(parse_json('[1, [1,2,3], true, {"k1": 1, "k2":
 true
 {"k1":1,"k2":2}
 
+statement error 1065
+SELECT * FROM json_array_elements(parse_json('[true]')) WHERE json_array_elements(parse_json('[true]'))
+
+statement error 1065
+SELECT * FROM json_array_elements(parse_json('[true]')) HAVING json_array_elements(parse_json('[true]'))
+
 query T
 select parse_json('["1","2","3"]') ? NULL
 ----
@@ -1107,6 +1119,12 @@ ORDER BY jq:key;
 2 {"key":"scores","value":"[92,88,95]"}
 3 {"key":"scores","value":"[76,80,82]"}
 
+statement error 1065
+SELECT * FROM test_data WHERE jq('.scores | min', json_data) > 85
+
+statement error 1065
+SELECT * FROM test_data HAVING jq('.scores | min', json_data) > 85
+
 statement ok
 DROP TABLE test_data;