Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove databend-common-{io, exception} from databend-common-ast #15618

Merged
merged 5 commits into from
May 23, 2024
Merged

chore: remove databend-common-{io, exception} from databend-common-ast #15618

merged 5 commits into from
May 23, 2024

Conversation

andylokandy
Copy link
Collaborator

@andylokandy andylokandy commented May 22, 2024 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Briefly describe what this PR aims to solve. Include background context that will help reviewers understand the purpose of the PR.

  • Fixes #[Link the issue here]

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label May 22, 2024
@youngsofun
Copy link
Member

some tests need to be updated

rest LGTM

@andylokandy andylokandy requested a review from sundy-li May 23, 2024 09:37
@andylokandy andylokandy added this pull request to the merge queue May 23, 2024
Merged via the queue into databendlabs:main with commit 9930d35 May 23, 2024
72 checks passed
@andylokandy andylokandy deleted the fixaset branch May 23, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youngsofun youngsofun youngsofun approved these changes

@sundy-li sundy-li Awaiting requested review from sundy-li

Assignees
No one assigned
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andylokandy @youngsofun