Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] chore: more merge into logs #15642

Closed

Conversation

dantengsky
Copy link
Member

@dantengsky dantengsky commented May 26, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Briefly describe what this PR aims to solve. Include background context that will help reviewers understand the purpose of the PR.

  • Fixes #[Link the issue here]

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

Copy link
Contributor

github-actions bot commented May 26, 2024

At least one test kind must be checked in the PR description.
@dantengsky please update it 🙏.

Copy link
Contributor

github-actions bot commented May 26, 2024

This pull request's title is not fulfill the requirements. @dantengsky please update it 🙏.

Valid format:

fix(query): fix group by string bug
  ^         ^---------------------^
  |         |
  |         +-> Summary in present tense.
  |
  +-------> Type: rfc, feat, fix, refactor, ci, docs, chore

Valid types:

  • rfc: this PR proposes a new RFC
  • feat: this PR introduces a new feature to the codebase
  • fix: this PR patches a bug in codebase
  • refactor: this PR changes the code base without new features or bugfix
  • ci: this PR changes build/testing/ci steps
  • docs: this PR changes the documents or websites
  • chore: this PR only has small changes that no need to record

Copy link
Contributor

github-actions bot commented May 26, 2024

At least one type of change must be checked in the PR description.
@dantengsky please update it 🙏.

@dantengsky dantengsky added the ci-cloud Build docker image for cloud test label May 26, 2024
Copy link
Contributor

Docker Image for PR

  • tag: pr-15642-3fce83f

note: this image tag is only available for internal use,
please check the internal doc for more details.

@dantengsky dantengsky closed this May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-cloud Build docker image for cloud test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant