-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: hilbert clustering #17045
Draft
zhyass
wants to merge
5
commits into
databendlabs:main
Choose a base branch
from
zhyass:feature_cluster_table
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
feat: hilbert clustering #17045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr-feature
this PR introduces a new feature to the codebase
label
Dec 12, 2024
zhyass
force-pushed
the
feature_cluster_table
branch
5 times, most recently
from
December 30, 2024 13:51
88111a3
to
059bb42
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Maybe should add performance test with hilbert clustering? |
zhyass
added
ci-cloud
Build docker image for cloud test
and removed
ci-cloud
Build docker image for cloud test
labels
Dec 31, 2024
This comment was marked as outdated.
This comment was marked as outdated.
zhyass
force-pushed
the
feature_cluster_table
branch
2 times, most recently
from
January 1, 2025 09:02
e5ea1e6
to
595cff9
Compare
zhyass
force-pushed
the
feature_cluster_table
branch
from
January 2, 2025 04:25
6ba61fd
to
c0c2183
Compare
zhyass
added
ci-cloud
Build docker image for cloud test
and removed
ci-cloud
Build docker image for cloud test
labels
Jan 2, 2025
Docker Image for PR
|
zhyass
force-pushed
the
feature_cluster_table
branch
from
January 2, 2025 05:47
c0c2183
to
2d183eb
Compare
zhyass
force-pushed
the
feature_cluster_table
branch
from
January 2, 2025 16:43
b336e03
to
ffdc058
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci-cloud
Build docker image for cloud test
pr-feature
this PR introduces a new feature to the codebase
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
This PR refines Hilbert clustering in Databend by adopting a range-based partitioning approach. It samples cluster keys, assigns range partition IDs, and calculates Hilbert indexes for efficient pruning and clustering. Key changes include:
Removing the old Hilbert clustering logic.
Stable segments are excluded from reclustering to preserve optimal clustering results.
The
alter table t recluster
is equivalent toTests
Type of change
This change is