fix(cluster): skip the recovery for warehouses that are not running state.

[zhang2014]

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

fix(cluster): fix recovery suspended warehouse

Tests

• Unit Test
• Logic Test
• Benchmark Test
• No Test - Explain why

Type of change

• Bug Fix (non-breaking change which fixes an issue)
• New Feature (non-breaking change which adds functionality)
• Breaking Change (fix or feature that could cause existing functionality not to work as expected)
• Documentation Update
• Refactoring
• Performance Improvement
• Other (please describe):

---

This change is 

[drmingdrmer]

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @BohuTANG and @zhang2014)

---

src/query/management/src/warehouse/warehouse_mgr.rs line 378 at r1 (raw file):

            if wh.status.to_uppercase() != "RUNNING" {
                continue;
            }

What about explicitly specifying the target to compare with? I'm not sure if there is going to be other status in future.

Suggestion:

            if wh.status.to_uppercase() == "SUSPENDED" {
                continue;
            }

[zhang2014]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @BohuTANG and @drmingdrmer)

---

src/query/management/src/warehouse/warehouse_mgr.rs line 378 at r1 (raw file):

Previously, drmingdrmer (张炎泼) wrote…

What about explicitly specifying the target to compare with? I'm not sure if there is going to be other status in future.

Done.

[drmingdrmer]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @BohuTANG)