Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed redirection from hisotry server on a proxy #18

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

DanielAronovich
Copy link
Contributor

Bug issue:
#13

Why it happened:

  1. The getProxyBasePath function:
    This implementation assumes that "/dataflint" is always the last meaningful part of the URL before the specific application details. However, in a proxy setup, there might be additional path segments between the host and "/dataflint", such as "/gateway/sparkhistory".

  2. The onHistoryServerClick function:
    This implementation uses BASE_PATH, which is likely a constant defined elsewhere in the application. The issue here is that BASE_PATH might not include the proxy-specific path segments (like "/gateway/sparkhistory") that are necessary to correctly construct the history server URL in a proxy setup.

Changes:

  1. getProxyBasePath function:

  2. onHistoryServerClick function:

    • Doesn't rely on BASE_PATH, avoiding issues with incorrect constant values.
    • Uses getProxyBasePath() to dynamically determine the correct base URL.
    • Adapts to both proxy and non-proxy environments without configuration changes.

@menishmueli menishmueli merged commit 1d6a2fb into dataflint:main Oct 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants