Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify how we use urlencode as a filter to account for double encoding with PIC #136

Open
reginafcompton opened this issue Jul 26, 2017 · 2 comments

Comments

@reginafcompton
Copy link
Contributor

Two things

Look at the filter here: https://github.com/datamade/django-councilmatic/blob/master/councilmatic_core/templates/councilmatic_core/legislation.html#L372

Add an explanatory note here: https://github.com/datamade/django-councilmatic/blob/master/councilmatic_core/models.py#L336

-OR-

We might think about how to standard full_text_doc_url for all Councilmatics, rather than expecting the city-specific Councilmatic to customize this. @fgregg, thoughts?

@fgregg
Copy link
Member

fgregg commented Jul 26, 2017

seems like a standard full_text_doc_url would be the way to go, particularly since the PIC url should be moved to settings variable

@reginafcompton
Copy link
Contributor Author

It looks like this model property varies among the Councilmatics (e.g., Chicago renders a PDF, but NYC does not). It seems like it would be best to allow for this type of flexibility and, instead, make the updates to Chicago and LA Metro, which need the double URL encoding.

https://github.com/datamade/django-councilmatic/blob/master/councilmatic_core/models.py#L336

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants