Allow null values for source_url #234
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgregg
requested changes
Feb 11, 2019
| @@ -179,7 +179,7 @@ class Bill(models.Model): | |||
| identifier = models.CharField(max_length=50) | |||
| bill_type = models.CharField(max_length=50) | |||
| classification = models.CharField(max_length=100) | |||
| source_url = models.CharField(max_length=255) | |||
There was a problem hiding this comment.
why can't we use the API url here. seems like that would make debugging easier in the future?
There was a problem hiding this comment.
yeah, I was waffling on this one, since Pupa requires a source_url....seems like Councilmatic should too.
If so, then I need to make a change in the scraper too, i.e., add a note to the source_url.
There was a problem hiding this comment.
Looks like I already opened an issue with a question about api vs. web: #227
|
@fgregg - I am going to close this PR in favor of scraper PR opencivicdata/scrapers-us-municipal#259 – which should fix the Sentry error. I think the way we import |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.